Talk:Style Guidelines: Difference between revisions

Isilkor (talk | contribs)
fwd decls
Isilkor (talk | contribs)
No edit summary
Line 2: Line 2:
[[User:Günther|Günther]]:
[[User:Günther|Günther]]:
* local headers before system headers
* local headers before system headers
* use static instead of anonymous namespaces
* don't forbid public data members
* don't forbid public data members
* <!Guenther> Demanding Doygen comments is also a very radical change
* <!Guenther> Demanding Doygen comments is also a very radical change
: <!Guenther> Doxygen is only really usefull if you are generating API docs that are intended to be read without looking at the source code
: <!Guenther> Doxygen is only really usefull if you are generating API docs that are intended to be read without looking at the source code
: <!Guenther> That's not a use case for us: our API is C4Script, not some C++ API
: <!Guenther> That's not a use case for us: our API is C4Script, not some C++ API
PeterW:
* order switch members by numeric value
Afterthoughts [[User:Isilkor|Isilkor]]:
Afterthoughts [[User:Isilkor|Isilkor]]:
* Use forward declarations instead of including the header inside other headers, if possible.
* Use forward declarations instead of including the header inside other headers, if possible.
Opinions:
* Use anonymous namespaces instead of static: '''In favor:''' ck?, Isilkor; '''Against:''' Günther, PeterW
* Doxygen comments: '''In favor:'''; '''Against:''' Günther, PeterW

Revision as of 15:34, 4 August 2009

Responses so far: Günther:

  • local headers before system headers
  • don't forbid public data members
  • <!Guenther> Demanding Doygen comments is also a very radical change
<!Guenther> Doxygen is only really usefull if you are generating API docs that are intended to be read without looking at the source code
<!Guenther> That's not a use case for us: our API is C4Script, not some C++ API

PeterW:

  • order switch members by numeric value

Afterthoughts Isilkor:

  • Use forward declarations instead of including the header inside other headers, if possible.

Opinions:

  • Use anonymous namespaces instead of static: In favor: ck?, Isilkor; Against: Günther, PeterW
  • Doxygen comments: In favor:; Against: Günther, PeterW